feat: add toggle for password field visibility#1252
Open
bntrtm wants to merge 1 commit into
Open
Conversation
Signed-off-by: bntrtm <git.bntrtm@tjbainter.com>
Pecacheu
approved these changes
Jun 3, 2026
Pecacheu
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, using a feature already built into mdui. (Tho just to note, I believe we aren't merging any more PRs atm waiting on a release candidate)
Dadadah
approved these changes
Jun 3, 2026
Member
|
Thanks for your contribution. Chu is correct, we will merge this after 0.8.0 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a password toggle to TextField components configured as passwords.
The changes are implemented by simply returning the appropriate
fieldConfigurationproperties pertinent to password visibility toggling as outlined by the MDUI documentation.The feature, widespread on the web today, greatly improves user login experience. Without it, users are disincentivized from using stronger passwords, as some may opt for a shorter and/or simpler one to avoid the potential headache of re-entering the password should a typo occur in the process.
How was this PR tested?
Screenshots & Screencasts (if appropriate)
These two screenshots show only the signup page, but it works all the same on the login page.
Checklist:
I have made corresponding changes to the documentation if applicableI have confirmed that any new dependencies are strictly necessaryI have written tests for new code (if applicable)Please declare, if any, LLM usage involved in creating this PR
None