Fix ticker extraction, swarm timeouts, and region warnings in finance assistant#247
Merged
manoj-selvakumar5 merged 3 commits intostrands-agents:mainfrom Apr 13, 2026
Conversation
… assistant - Fix ticker defaulting to AMZN when orchestrator passes full sentences by adding _extract_ticker() helper with regex-based extraction - Include ticker in all swarm agent system prompts so financial_analyst and market_analyst know which company to analyze - Increase node_timeout from 30s to 90s and execution_timeout from 120s to 300s to prevent premature timeout errors - Remove deprecated `region` parameter from BedrockModel calls - Update model to Opus 4.6 via configurable constants - Update orchestrator prompt to instruct passing ticker symbols only
|
Latest scan for commit: ✅ Security Scan Report (PR Files Only)Scanned Files
Security Scan Results
Threshold: High No security issues detected in your changes. Great job! This scan only covers files changed in this PR. |
Update swarm model comment to accurately reflect Opus usage instead of claiming "use a fast model". Remove no-op region="us-east-1" from BedrockModel calls in standalone agents (BedrockModel accepts region_name, not region).
manoj-selvakumar5
approved these changes
Apr 13, 2026
manoj-selvakumar5
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_extract_ticker()helperregionparameter from BedrockModel callsTest plan
uv run finance_assistant_swarm.pywith tickerALKInvalid configuration parameters: ['region']warningsStatus.COMPLETED