Skip to content

Conversation

@sjoukedv
Copy link

@sjoukedv sjoukedv commented Feb 5, 2026

What does it do?

Bump node engine constraint maximum

Why is it needed?

Node v24 is the latest LTS version

Related issue(s)/PR(s)

Fixes #112

Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
@dosubot
Copy link

dosubot bot commented Feb 5, 2026

Related Documentation

Checked 7 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@sjoukedv
Copy link
Author

sjoukedv commented Feb 5, 2026

@jhoward1994 / @nclsndr could you give this a quick review?

@nclsndr nclsndr self-assigned this Feb 9, 2026
@nclsndr
Copy link
Contributor

nclsndr commented Feb 9, 2026

Thank you @sjoukedv for raising this PR!
I'll take care of reviewing it asap.

Side note: in general, please avoid mentioning strapi maintainers directly on GH for new issue or PR. We have automated tracking and triage of new PRs, direct mentions mainly adds noise to this management. Thank you for your understanding 🙏

@nclsndr nclsndr self-requested a review February 9, 2026 16:35
Copy link
Contributor

@nclsndr nclsndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change by itself is legit.
Yet, we also need to add node 24 in .github/workflows so that we guarantee the CI also checks for that version.

@sjoukedv let me know if you'd like to do it, otherwise I'd replay those changes in another PR.

@nclsndr nclsndr changed the title fix(engines): bump node max version to v24.x.x LTS chore(engines): bump node max version to v24.x.x LTS Feb 9, 2026
@nclsndr nclsndr added the pr: chore Cleanups / dependencies / tooling / styling label Feb 9, 2026
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
@sjoukedv
Copy link
Author

sjoukedv commented Feb 9, 2026

Thank you @sjoukedv for raising this PR! I'll take care of reviewing it asap.

Side note: in general, please avoid mentioning strapi maintainers directly on GH for new issue or PR. We have automated tracking and triage of new PRs, direct mentions mainly adds noise to this management. Thank you for your understanding 🙏

Sure, I had no idea how active this repository is considering the client is relatively new (at least for me). This was the only package for my application that did not support node v24 making me downgrade to v22. It's getting very confusing and frustrating with all the cross @strapi/ package node engine constraint, but also their dependency version amongst each other. Would be great to have automation in place to automatically bump the node version everywhere or a package constraint.

The change by itself is legit. Yet, we also need to add node 24 in .github/workflows so that we guarantee the CI also checks for that version.

@sjoukedv let me know if you'd like to do it, otherwise I'd replay those changes in another PR.

Done! I left 20 in there. Let me know if you would like to have it removed @nclsndr .

Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: chore Cleanups / dependencies / tooling / styling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat]: Node 24 support

2 participants