-
Notifications
You must be signed in to change notification settings - Fork 15
chore(engines): bump node max version to v24.x.x LTS #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
|
@jhoward1994 / @nclsndr could you give this a quick review? |
|
Thank you @sjoukedv for raising this PR! Side note: in general, please avoid mentioning strapi maintainers directly on GH for new issue or PR. We have automated tracking and triage of new PRs, direct mentions mainly adds noise to this management. Thank you for your understanding 🙏 |
nclsndr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change by itself is legit.
Yet, we also need to add node 24 in .github/workflows so that we guarantee the CI also checks for that version.
@sjoukedv let me know if you'd like to do it, otherwise I'd replay those changes in another PR.
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
Sure, I had no idea how active this repository is considering the client is relatively new (at least for me). This was the only package for my application that did not support node v24 making me downgrade to v22. It's getting very confusing and frustrating with all the cross
Done! I left |
Signed-off-by: Sjouke de Vries <info@sdvservices.nl>
What does it do?
Bump node engine constraint maximum
Why is it needed?
Node v24 is the latest LTS version
Related issue(s)/PR(s)
Fixes #112