Skip to content

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Oct 23, 2025

@mulkieran mulkieran self-assigned this Oct 23, 2025
@mulkieran mulkieran moved this to Pending in 2025October Oct 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

Three GitHub Actions workflow files were updated to use the Fedora container image fedora:42 instead of fedora:41 for CI jobs.

Changes

Cohort / File(s) Summary
Container Image Version Updates
.github/workflows/cargo.yml, .github/workflows/main.yml, .github/workflows/nightly.yml
Replaced container image fedora:41 with fedora:42 in CI workflow jobs. No other logic changes.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Focus review on the three workflow files to confirm only the image tag changed and no unintended edits occurred.

Possibly related PRs

Poem

🐰 I hopped from forty-one to forty-two,
Pipelines snug in a brand-new shoe,
Containers warmed and ready to go,
Tests will hum and builds will flow,
A little hop — CI's fresh and true. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Increase CURRENT DEVELOPMENT ENVIRONMENT to Fedora 42" clearly and accurately describes the main change in the changeset. The changes across all three workflow files (.github/workflows/cargo.yml, main.yml, and nightly.yml) involve updating the Fedora container image version from 41 to 42, which directly corresponds to the stated objective of increasing the development environment to Fedora 42. The title is concise, specific, and conveys meaningful information without unnecessary noise, making it easy for teammates to understand the primary intent of the change when scanning commit history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec1ded4 and 6e007fb.

📒 Files selected for processing (3)
  • .github/workflows/cargo.yml (1 hunks)
  • .github/workflows/main.yml (1 hunks)
  • .github/workflows/nightly.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/workflows/nightly.yml
  • .github/workflows/cargo.yml
  • .github/workflows/main.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (21)
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-43-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-rawhide-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-42-x86_64:copr_pull
  • GitHub Check: rpm-build:fedora-41-x86_64:copr_pull
  • GitHub Check: tests-with-sudo (1.90.0)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-devicemapper-rs-1009
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Signed-off-by: the Mulhern <amulhern@amulhern.bos.csb>
@mulkieran mulkieran added this to the devicemapper-v0.34.6 milestone Oct 30, 2025
@mulkieran mulkieran merged commit c042bcb into stratis-storage:master Oct 30, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Pending to Done in 2025October Oct 30, 2025
@mulkieran mulkieran deleted the issue_project_805 branch October 30, 2025 22:47
@mulkieran mulkieran moved this from Done to Done(3) in 2025October Nov 4, 2025
@mulkieran mulkieran moved this from Done(3) to Done(4) in 2025October Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(4)

Development

Successfully merging this pull request may close these issues.

1 participant