Add Precommit to repo and update formatting #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-kmcgrady
force-pushed
the
feature/pre-commit
branch
5 times, most recently
from
6e54956 to
a26a2bd
Compare
There was a problem hiding this comment.
is this file needed? The reference is commented out
sfc-gh-braethlein
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
The changes look good, but i think adding pre-commit without having it enforced in CI isn't very useful. Can we add a workflow for this as well like: https://github.com/streamlit/streamlit/blob/develop/.github/workflows/enforce-pre-commit.yml
sfc-gh-kmcgrady
force-pushed
the
feature/pre-commit
branch
2 times, most recently
from
134aec0 to
b0a104d
Compare
sfc-gh-kmcgrady
force-pushed
the
feature/pre-commit
branch
from
b0a104d to
61ec1ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce pre-commit. It will ensure the following:
Open to other pre-commit ideas, but this seems like a solid start for a simple component.