This repository was archived by the owner on Dec 14, 2022. It is now read-only.
emit Pulsar source and sink configuration property values to logs #335#351
Open
gaozhangmin wants to merge 3 commits intostreamnative:masterfrom
Open
emit Pulsar source and sink configuration property values to logs #335#351gaozhangmin wants to merge 3 commits intostreamnative:masterfrom
gaozhangmin wants to merge 3 commits intostreamnative:masterfrom
Conversation
jianyun8023
reviewed
Jun 15, 2021
...onnector/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarSinkBase.java
Show resolved
Hide resolved
...-connector/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarSource.java
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
log-sink-source-config
branch
from
400f36d to
8def568
Compare
syhily
reviewed
Aug 27, 2021
...onnector/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarSinkBase.java
Outdated
Show resolved
Hide resolved
gaozhangmin
force-pushed
the
log-sink-source-config
branch
from
8def568 to
ef03236
Compare
Contributor
|
@gaozhangmin I think you still need to use a shaded jackson based on @jianyun8023's review opinion. |
Contributor
Author
@syhily done |
nlu90
reviewed
Nov 5, 2021
Contributor
nlu90
left a comment
nlu90
left a comment
There was a problem hiding this comment.
Do you want to make the log to DEBUG level?
Contributor
|
The configuration may contain some authentication config options. Change to debug level may sound better. Or we can print the |
gaozhangmin
force-pushed
the
log-sink-source-config
branch
from
f658bb9 to
ccfc9a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #335