This repository was archived by the owner on Dec 14, 2022. It is now read-only.
[ENHANCEMENT] enhancement for setting up auth parameters#380
Open
wuzhanpeng wants to merge 2 commits intostreamnative:masterfrom
Open
[ENHANCEMENT] enhancement for setting up auth parameters#380wuzhanpeng wants to merge 2 commits intostreamnative:masterfrom
wuzhanpeng wants to merge 2 commits intostreamnative:masterfrom
Conversation
syhily
reviewed
Aug 27, 2021
| } | ||
|
|
||
| public static void setupAuthIfNeed(ClientConfigurationData conf, Properties properties) { | ||
| if (!StringUtils.isBlank(conf.getAuthPluginClassName()) && !StringUtils.isBlank(conf.getAuthParams())) { |
Contributor
There was a problem hiding this comment.
This logic may not looks like right. We support both authParams and authMap. So you may need to check the authMap here.
Contributor
Author
There was a problem hiding this comment.
I add a check for authMap and PTAL~ @syhily
Contributor
|
OK, LGTM. But this is only a hotfix we may perform a code cleanup and refactor these complex logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
When I tried to create
FlinkPulsarSourcein the following way,I found my flink job was failed and I can see some warnning logs in my broker like:
The reason for this problem is that only setting auth params in
Propertieswill not take effect in the final initialization ofPulsarClient.Modifications
Add some extra checking for this issue.