fix(sdk): [NET-1462] StreamrClient#searchStreams() queries using Stream entity
#3132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
changed the title
StreamrClient#searchStreams() queries using Stream entityStreamrClient#searchStreams() queries using Stream entity
teogeb
added a commit
to streamr-dev/network-contracts
that referenced
this pull request
May 23, 2025
Added new field to `Stream` entity: `Stream#idAsString`. It has same value as in the `id` field. The field allows us do to substring queries for the field id (by using `idAsString_contains` where clause). This feature is needed e.g. in streamr-dev/network#3132.
…reamPermission entitity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3131, merge that first. This also needs streamr-dev/network-contracts#994 to be deployed to production. The tests in this PR should pass once streamr-docker-dev has been updated to have an up-to-date image of
deploy-network-subgraphs-fastchain.Changed the
StreamrClient#searchStreams()to useStreamentity directly. The previous implementation used theStreamPermissionentity, which made the queries more complex and slower. See benchmarks below.This also fixes a potential bug as the previous implementation relied on the contents of
StreamPermission#idto be prefixed with stream id. Most or all of the IDs in our subgraphs have used that kind of id format, but it is not a documented feature of the subgraphs.Benchmarks
The benchmarks were run in
dev2environment which had ~10000 streamsTODO