change coroutine context for image repo (#11635)

* change coroutine context for image repo

* Fix checks.

---------

Co-authored-by: Jay Newstrom <jaynewstrom@stripe.com>

Author: amk-stripe

3ds2sdk/src/main/kotlin/com/stripe/android/stripe3ds2/views/ChallengeActivity.kt

@@ -77,7 +77,6 @@ class ChallengeActivity : AppCompatActivity() {
             challengeActionHandler,
             transactionTimer,
             errorReporter,
-            WORK_CONTEXT
         )
     }
 
@@ -108,7 +107,6 @@ class ChallengeActivity : AppCompatActivity() {
             challengeActionHandler = challengeActionHandler,
             intentData = viewArgs.intentData,
             initialUiType = viewArgs.cresData.uiType,
-            workContext = WORK_CONTEXT
         )
 
         super.onCreate(savedInstanceState)

3ds2sdk/src/main/kotlin/com/stripe/android/stripe3ds2/views/ChallengeActivityViewModel.kt

@@ -17,16 +17,14 @@ import com.stripe.android.stripe3ds2.utils.ImageCache
 import kotlinx.coroutines.Job
 import kotlinx.coroutines.flow.firstOrNull
 import kotlinx.coroutines.launch
-import kotlin.coroutines.CoroutineContext
 
 internal class ChallengeActivityViewModel(
     private val challengeActionHandler: ChallengeActionHandler,
     private val transactionTimer: TransactionTimer,
     errorReporter: ErrorReporter,
     private val imageCache: ImageCache = ImageCache.Default,
-    workContext: CoroutineContext
 ) : ViewModel() {
-    private val imageRepository = ImageRepository(errorReporter, workContext)
+    private val imageRepository = ImageRepository(errorReporter, viewModelScope.coroutineContext)
 
     private val _refreshUi = MutableLiveData<Unit>()
     val refreshUi: LiveData<Unit> = _refreshUi
@@ -124,7 +122,6 @@ internal class ChallengeActivityViewModel(
         private val challengeActionHandler: ChallengeActionHandler,
         private val transactionTimer: TransactionTimer,
         private val errorReporter: ErrorReporter,
-        private val workContext: CoroutineContext
     ) : ViewModelProvider.Factory {
 
         @Suppress("UNCHECKED_CAST")
@@ -133,7 +130,6 @@ internal class ChallengeActivityViewModel(
                 challengeActionHandler,
                 transactionTimer,
                 errorReporter,
-                workContext = workContext
             ) as T
         }
     }

3ds2sdk/src/main/kotlin/com/stripe/android/stripe3ds2/views/ChallengeFragment.kt

@@ -26,7 +26,6 @@ import com.stripe.android.stripe3ds2.transactions.ChallengeResponseData
 import com.stripe.android.stripe3ds2.transactions.ErrorData
 import com.stripe.android.stripe3ds2.transactions.UiType
 import com.stripe.android.stripe3ds2.utils.AnalyticsDelegate
-import kotlin.coroutines.CoroutineContext
 
 internal class ChallengeFragment(
     private val uiCustomization: StripeUiCustomization,
@@ -37,7 +36,6 @@ internal class ChallengeFragment(
     private val challengeActionHandler: ChallengeActionHandler,
     private val initialUiType: UiType?,
     private val intentData: IntentData,
-    private val workContext: CoroutineContext
 ) : Fragment(R.layout.stripe_challenge_fragment) {
 
     private lateinit var cresData: ChallengeResponseData
@@ -49,7 +47,6 @@ internal class ChallengeFragment(
             challengeActionHandler,
             transactionTimer,
             errorReporter,
-            workContext
         )
     }
 

3ds2sdk/src/main/kotlin/com/stripe/android/stripe3ds2/views/ChallengeFragmentFactory.kt

@@ -10,7 +10,6 @@ import com.stripe.android.stripe3ds2.transaction.IntentData
 import com.stripe.android.stripe3ds2.transaction.TransactionTimer
 import com.stripe.android.stripe3ds2.transactions.UiType
 import com.stripe.android.stripe3ds2.utils.AnalyticsDelegate
-import kotlin.coroutines.CoroutineContext
 
 internal class ChallengeFragmentFactory(
     private val uiCustomization: StripeUiCustomization,
@@ -21,7 +20,6 @@ internal class ChallengeFragmentFactory(
     private val challengeActionHandler: ChallengeActionHandler,
     private val initialUiType: UiType?,
     private val intentData: IntentData,
-    private val workContext: CoroutineContext
 ) : FragmentFactory() {
     override fun instantiate(classLoader: ClassLoader, className: String): Fragment {
         return when (className) {
@@ -35,7 +33,6 @@ internal class ChallengeFragmentFactory(
                     challengeActionHandler,
                     initialUiType,
                     intentData,
-                    workContext
                 )
             }
             else -> {

3ds2sdk/src/test/kotlin/com/stripe/android/stripe3ds2/views/ChallengeActivityViewModelTest.kt

@@ -11,7 +11,6 @@ import com.stripe.android.stripe3ds2.transaction.ChallengeRequestResultFixures
 import com.stripe.android.stripe3ds2.transaction.FakeTransactionTimer
 import com.stripe.android.stripe3ds2.transaction.TransactionTimer
 import kotlinx.coroutines.cancel
-import kotlinx.coroutines.test.StandardTestDispatcher
 import org.junit.Rule
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
@@ -22,8 +21,6 @@ class ChallengeActivityViewModelTest {
     @get:Rule
     val rule = InstantTaskExecutorRule()
 
-    private val testDispatcher = StandardTestDispatcher()
-
     private val actionHandler = object : ChallengeActionHandler {
         override suspend fun submit(action: ChallengeAction): ChallengeRequestResult {
             return ChallengeRequestResultFixures.SUCCESS
@@ -72,7 +69,6 @@ class ChallengeActivityViewModelTest {
             actionHandler,
             transactionTimer,
             FakeErrorReporter(),
-            workContext = testDispatcher
         )
     }
 }

3ds2sdk/src/test/kotlin/com/stripe/android/stripe3ds2/views/ChallengeFragmentTest.kt

@@ -21,7 +21,6 @@ import com.stripe.android.stripe3ds2.transaction.TransactionTimer
 import com.stripe.android.stripe3ds2.transactions.ChallengeResponseData
 import com.stripe.android.stripe3ds2.transactions.UiType
 import com.stripe.android.stripe3ds2.utils.FakeAnalyticsDelegate
-import kotlinx.coroutines.test.StandardTestDispatcher
 import org.junit.Rule
 import org.junit.runner.RunWith
 import org.mockito.kotlin.mock
@@ -38,8 +37,6 @@ class ChallengeFragmentTest {
     @get:Rule
     val rule = InstantTaskExecutorRule()
 
-    private val testDispatcher = StandardTestDispatcher()
-
     private val transactionTimer: TransactionTimer = FakeTransactionTimer(false)
     private val errorReporter: ErrorReporter = FakeErrorReporter()
     private val challengeActionHandler = FakeChallengeActionHandler()
@@ -373,7 +370,6 @@ class ChallengeFragmentTest {
                 challengeActionHandler = challengeActionHandler,
                 intentData = IntentDataFixtures.DEFAULT,
                 initialUiType = UiType.Text,
-                workContext = testDispatcher
             )
         ).onFragment(onFragment)
     }