Skip to content

Conversation

@jaynewstrom-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │   1.1 MiB │   1.1 MiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.7 KiB │ 302.7 KiB │  0 B │ 456.5 KiB │ 456.5 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │  0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │  0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ +5 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  11.5 MiB │  11.5 MiB │ +5 B │  25.4 MiB │  25.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20710 │ 20710 │ 0 (+0 -0) 
   types │  6515 │  6515 │ 0 (+0 -0) 
 classes │  5279 │  5279 │ 0 (+0 -0) 
 methods │ 31555 │ 31555 │ 0 (+0 -0) 
  fields │ 18279 │ 18279 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  163 │  163 │  0   
 entries │ 3665 │ 3665 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 29.2 KiB │ +5 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    272 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 25.9 KiB │ +1 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │ +5 B │ 130.5 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-ExperimentalPaymentSheetDecouplingApi branch from 7a9421e to 9065baf Compare September 26, 2025 14:07
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-ExperimentalPaymentSheetDecouplingApi branch from 9065baf to 5923119 Compare October 6, 2025 20:33
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-ExperimentalPaymentSheetDecouplingApi branch 2 times, most recently from e19cb3d to ed6a455 Compare October 16, 2025 13:11
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-ExperimentalPaymentSheetDecouplingApi branch from ed6a455 to 7ff34ec Compare October 22, 2025 13:17
@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/remove-ExperimentalPaymentSheetDecouplingApi branch from 7ff34ec to 49918ad Compare October 27, 2025 13:31
@cttsai-stripe
Copy link
Contributor

Can we merge this PR now if it is unused?

@jaynewstrom-stripe
Copy link
Collaborator Author

It's a public class, we could merge it now based on our policy today, but we should just wait 1 day since we've already waited this long.

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review October 28, 2025 12:36
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners October 28, 2025 12:36
@jaynewstrom-stripe jaynewstrom-stripe merged commit d56be16 into master Oct 28, 2025
19 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/remove-ExperimentalPaymentSheetDecouplingApi branch October 28, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants