Replace size and length comparisons with isEmpty()

Author: yawnoc

CHANGELOG.md

@@ -12,6 +12,7 @@
 - Upgraded Android Gradle Plugin to 8.10.1
 - Fixed various Gradle-related deprecations
 - Replaced `printStackTrace()` with logging
+- Replaced `size()` and `length()` comparisons with `isEmpty()` check
 
 
 ## [v1.4.2] (68) 煮者 (2025-01-12)

app/src/main/java/io/github/yawnoc/strokeinput/StrokeInputService.java

@@ -219,7 +219,7 @@ private Keyboard loadSavedKeyboard()
   @SuppressWarnings("BooleanMethodIsAlwaysInverted")
   private static boolean isCommentLine(final String line)
   {
-    return line.startsWith("#") || line.length() == 0;
+    return line.startsWith("#") || line.isEmpty();
   }
 
   @SuppressWarnings("SameParameterValue")
@@ -565,7 +565,7 @@ private void effectStrokeAppend(final String strokeDigit)
   {
     final String newStrokeDigitSequence = strokeDigitSequence + strokeDigit;
     final List<String> newCandidates = computeCandidates(newStrokeDigitSequence);
-    if (newCandidates.size() > 0)
+    if (!newCandidates.isEmpty())
     {
       setStrokeDigitSequence(newStrokeDigitSequence);
       setCandidates(newCandidates);
@@ -574,15 +574,15 @@ private void effectStrokeAppend(final String strokeDigit)
 
   private void effectBackspace(final InputConnection inputConnection)
   {
-    if (strokeDigitSequence.length() > 0)
+    if (!strokeDigitSequence.isEmpty())
     {
       final String newStrokeDigitSequence = Stringy.removeSuffixRegex("(?s).", strokeDigitSequence);
       final List<String> newCandidates = computeCandidates(newStrokeDigitSequence);
 
       setStrokeDigitSequence(newStrokeDigitSequence);
       setCandidates(newCandidates);
 
-      if (newStrokeDigitSequence.length() == 0)
+      if (newStrokeDigitSequence.isEmpty())
       {
         setPhraseCompletionCandidates(inputConnection);
       }
@@ -593,7 +593,7 @@ private void effectBackspace(final InputConnection inputConnection)
     {
       final String upToOneCharacterBeforeCursor = getTextBeforeCursor(inputConnection, 1);
 
-      if (upToOneCharacterBeforeCursor.length() > 0)
+      if (!upToOneCharacterBeforeCursor.isEmpty())
       {
         final CharSequence selection = inputConnection.getSelectedText(0);
         if (TextUtils.isEmpty(selection))
@@ -629,7 +629,7 @@ private void effectKeyboardSwitch(final String keyboardName)
 
   private void effectSpaceKey(final InputConnection inputConnection)
   {
-    if (strokeDigitSequence.length() > 0)
+    if (!strokeDigitSequence.isEmpty())
     {
       onCandidate(getFirstCandidate());
     }
@@ -641,7 +641,7 @@ private void effectSpaceKey(final InputConnection inputConnection)
 
   private void effectEnterKey(final InputConnection inputConnection)
   {
-    if (strokeDigitSequence.length() > 0)
+    if (!strokeDigitSequence.isEmpty())
     {
       onCandidate(getFirstCandidate());
     }
@@ -657,7 +657,7 @@ else if (enterKeyHasAction)
 
   private void effectOrdinaryKey(final InputConnection inputConnection, final String valueText)
   {
-    if (strokeDigitSequence.length() > 0)
+    if (!strokeDigitSequence.isEmpty())
     {
       return;
     }
@@ -820,7 +820,7 @@ private int computeCandidateRank(
     final int fineRank;
     final int penalty;
 
-    final boolean phraseCompletionsIsEmpty = phraseCompletionFirstCodePoints.size() == 0;
+    final boolean phraseCompletionsIsEmpty = phraseCompletionFirstCodePoints.isEmpty();
     final int phraseCompletionIndex = phraseCompletionFirstCodePoints.indexOf(firstCodePoint);
     final boolean firstCodePointMatchesPhraseCompletionCandidate = phraseCompletionIndex > 0;
 
@@ -864,7 +864,7 @@ else if (firstCodePointMatchesPhraseCompletionCandidate)
 
   private List<String> computeCandidates(final String strokeDigitSequence)
   {
-    if (strokeDigitSequence.length() == 0)
+    if (strokeDigitSequence.isEmpty())
     {
       return Collections.emptyList();
     }
@@ -947,7 +947,7 @@ private List<String> computePhraseCompletionCandidates(final InputConnection inp
 
     for (
       String phrasePrefix = getTextBeforeCursor(inputConnection, MAX_PHRASE_LENGTH - 1);
-      phrasePrefix.length() > 0;
+      !phrasePrefix.isEmpty();
       phrasePrefix = Stringy.removePrefixRegex("(?s).", phrasePrefix)
     )
     {

app/src/main/java/io/github/yawnoc/strokeinput/StrokeSequenceBar.java

@@ -1,5 +1,5 @@
 /*
-  Copyright 2021, 2023 Conway
+  Copyright 2021, 2023, 2025 Conway
   Licensed under the GNU General Public License v3.0 (GPL-3.0-only).
   This is free software with NO WARRANTY etc. etc.,
   see LICENSE or <https://www.gnu.org/licenses/>.
@@ -25,7 +25,7 @@ public StrokeSequenceBar(Context context, AttributeSet attributes)
 
   public void setStrokeDigitSequence(final String strokeDigitSequence)
   {
-    if (strokeDigitSequence.length() > 0)
+    if (!strokeDigitSequence.isEmpty())
     {
       final String strokeSequence =
               strokeDigitSequence