Skip to content

Commit 1d77ce9

Browse files
authored
Merge pull request #94 from sasezaki/reason-tip
Refactor to use acceptsReasonsTip() for consistent error message handling
2 parents ebe1946 + d3f5898 commit 1d77ce9

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/Rules/ContextTypeRule.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
use Sfp\PHPStan\Psr\Log\TypeProviderResolver\ContextTypeProviderResolverInterface;
1818

1919
use function count;
20-
use function implode;
2120
use function in_array;
2221
use function sprintf;
2322

@@ -99,12 +98,9 @@ public function processNode(Node $node, Scope $scope): array
9998
(string) $argContextType->toPhpDocNode()
10099
)
101100
)
101+
->acceptsReasonsTip($acceptsResult->reasons)
102102
->identifier('sfpPsrLog.contextType');
103103

104-
if (count($acceptsResult->reasons) > 0) {
105-
$ruleErrorBuilder->tip(implode(',', $acceptsResult->reasons));
106-
}
107-
108104
return [
109105
$ruleErrorBuilder->build(),
110106
];

src/Rules/LogMethodLevelRule.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,10 @@ public function processNode(Node $node, Scope $scope): array
9696
$this->acceptingLogLevel->toPhpDocNode()->__toString(),
9797
$argLevel->toPhpDocNode()->__toString()
9898
)
99-
)->identifier('sfpPsrLog.logMethodLevel')->build(),
99+
)
100+
->acceptsReasonsTip($acceptsResult->reasons)
101+
->identifier('sfpPsrLog.logMethodLevel')
102+
->build(),
100103
];
101104
}
102105
}

0 commit comments

Comments
 (0)