cost-tracking: add testing infrastructure #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureeves
force-pushed
the
test/cost-tracking
branch
2 times, most recently
from
54f1ea8 to
66b9e50
Compare
In this commit we add the infrastructure necessary to test the runtime's cost tracking. We take advantage of the tests that already exist to check the interpreter and the runtime match in the results that they produce, and add an assertion that the tracked costs should also be equivalent. To trigger the cost tracking tests, a new feature `test-cost-tracking` is added. By default cost tracking checks are *not* included, to preserve current behavior. We also add the tests to the CI infrastructure, by adding a new matrix field controlling if we test with cost tracking or not. Resolves: #636
ureeves
force-pushed
the
test/cost-tracking
branch
from
66b9e50 to
5bf7385
Compare
This was referenced Jun 23, 2025
ureeves
force-pushed
the
test/cost-tracking
branch
from
c078d5e to
cdcaa30
Compare
|
|
|
Closed in favor of #735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we add the infrastructure necessary to test the runtime's cost tracking. We take advantage of the tests that already exist to check the interpreter and the runtime match in the results that they produce, and add an assertion that the tracked costs should also be equivalent.
To trigger the cost tracking tests, a new feature
test-cost-trackingis added. By default cost tracking checks are not included, to preserve current behavior.We also add the tests to the CI infrastructure, by adding a new matrix field controlling if we test with cost tracking or not.
Resolves: #636