Skip to content

fix: Fix a regression from the v7.x.x update where the localnet/mock… #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janniks merged 3 commits into from
May 13, 2025
Merged

fix: Fix a regression from the v7.x.x update where the localnet/mock… #1795

janniks merged 3 commits into from
May 13, 2025

Conversation

@janniks
Copy link
Contributor

@janniks janniks commented May 7, 2025 •
edited by github-actions bot
Loading

This PR was published to npm with the version 7.0.7-pr.2+de94b530
e.g. npm install @stacks/common@7.0.7-pr.2+de94b530 --save-exact

  • Fixes a regression that always used testnet/mainnet when we switched to the static network object style.
  • Adds tests to avoid future regressions

@janniks janniks requested a review from zone117x May 7, 2025 15:25
@vercel
Copy link

vercel bot commented May 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2025 3:10pm

@codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/cli.ts 62.50% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

zone117x
zone117x approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janniks janniks merged commit c9aef87 into main May 13, 2025
9 checks passed
@janniks janniks deleted the fix/regression-localnet-flag branch May 13, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zone117x zone117x zone117x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janniks @zone117x