Skip to content

Conversation

@peterdj45
Copy link
Member

@peterdj45 peterdj45 marked this pull request as ready for review May 21, 2025 19:00
@peterdj45 peterdj45 requested a review from a team as a code owner May 21, 2025 19:00
@peterdj45 peterdj45 added the in-test-rules PR is in our testing suite to collect telemetry label May 21, 2025
@peterdj45
Copy link
Member Author

/update-test-rules

github-actions bot pushed a commit that referenced this pull request May 21, 2025
Create monday_infra_abuse.yml by @peterdj45
#2729
Source SHA af107e7
Triggered by @peterdj45
@MSAdministrator
Copy link
Member

I may be missing something but the samples provided above didn't match the rule itself or maybe I'm not doing something right lol. At least the first two samples also didn't have any attachments but did have the trackingservice.monday.com link

@peterdj45
Copy link
Member Author

peterdj45 commented Sep 5, 2025

I may be missing something but the samples provided above didn't match the rule itself or maybe I'm not doing something right lol. At least the first two samples also didn't have any attachments but did have the trackingservice.monday.com link

Ah, those were sent via salesforce and are hitting our high trust sender domain negation. I added an or statement to flag messages sent via SFDC

@peterdj45 peterdj45 added the review-needed Indicates that a PR is waiting for review label Sep 5, 2025
@morriscode
Copy link
Member

The OR on line 97 is unencapsulated

@peterdj45 peterdj45 removed the review-needed Indicates that a PR is waiting for review label Sep 10, 2025
@peterdj45
Copy link
Member Author

I incorporated a topic check to filter out B2B cold outreach, and fixed the unencapsulated OR. I'll let this bake in test-rules over the weekend

Copy link
Member

@IndiaAce IndiaAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, but we might need to expand the negation for graymail and newsletters. I still see a bunch of what looks like benign matches in Mode

use monday_tracker url decoder
unnest the or statements that use different attachment length logic to be their own
Co-authored-by: Luke Wescott <69780712+IndiaAce@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-test-rules PR is in our testing suite to collect telemetry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants