fix: builds

Author: prestwich

.github/workflows/tests.yaml

@@ -39,7 +39,7 @@ jobs:
       - uses: Swatinem/rust-cache@v2
       - name: check
         run: |
-          cargo check \
+          RUSTFLAGS='--cfg getrandom_backend="wasm_js"' cargo check \
           --target wasm32-unknown-unknown \
           --no-default-features \
           --features browser

build.sh

@@ -2,24 +2,28 @@
 
 set -e
 
-cargo build
-cargo test --lib
-cargo test --doc
+# simple function to print on fail
+fail() {
+    echo ""
+    echo "Build failed: $1"
+    exit 1
+}
+
+cargo c -q || fail "Cargo build"
+cargo test -q --workspace || fail "Cargo workspace tests"
+cargo test -q --doc || fail "Cargo documentation tests"
 
 ### BIP32 ###
-cd crates/bip32
-cargo build
-cargo build --no-default-features
-cargo build --target wasm32-unknown-unknown
+cargo c -q -p coins-bip32 || fail "BIP32 build failed"
+cargo c -q -p coins-bip32 --no-default-features || fail "BIP32 build without default features"
+RUSTFLAGS='--cfg getrandom_backend="wasm_js"' cargo c -q -p coins-bip32 --target wasm32-unknown-unknown || fail "BIP32 wasm build "
 
 ### BIP39 ###
-cd ../bip39
-cargo build
-cargo build --no-default-features
-cargo build --target wasm32-unknown-unknown
+cargo c -q -p coins-bip39 || fail "BIP39 build"
+cargo c -q -p coins-bip39 --no-default-features || fail "BIP39 build without default features"
+RUSTFLAGS='--cfg getrandom_backend="wasm_js"' cargo c -q -p coins-bip39 --target wasm32-unknown-unknown || fail "BIP39 wasm build"
 
 ### Ledger ###
-cd ../ledger
 # #  broken on travis
-# cargo build
-cargo build --target wasm32-unknown-unknown --no-default-features --features="browser"
+# cargo c -q
+cargo c -q -p coins-ledger --target wasm32-unknown-unknown --no-default-features --features="browser" || fail "Ledger wasm build "

crates/bip32/Cargo.toml

@@ -23,6 +23,10 @@ serde.workspace = true
 sha2.workspace = true
 thiserror.workspace = true
 
+[target.'cfg(target_arch = "wasm32")'.dependencies]
+gr03 = { package = "getrandom", version = "0.3", features = ["wasm_js"] }
+gr02 = { package = "getrandom", version = "0.2", features = ["js"] }
+
 [dev-dependencies]
 hex.workspace = true
 

crates/bip32/src/lib.rs

@@ -173,3 +173,9 @@ impl From<std::convert::Infallible> for Bip32Error {
         unimplemented!("unreachable, but required by type system")
     }
 }
+
+#[cfg(target_arch = "wasm32")]
+mod _silence_warnings {
+    use gr02 as _;
+    use gr03 as _;
+}

crates/bip39/Cargo.toml

@@ -27,7 +27,8 @@ sha2.workspace = true
 thiserror.workspace = true
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
-getrandom = { version = "0.3", features = ["wasm_js"] }
+gr03 = { package = "getrandom", version = "0.3", features = ["wasm_js"] }
+gr02 = { package = "getrandom", version = "0.2", features = ["js"] }
 
 [dev-dependencies]
 hex.workspace = true

crates/bip39/src/lib.rs

@@ -21,3 +21,9 @@ pub use self::mnemonic::*;
 /// Wordlists
 pub mod wordlist;
 pub use self::wordlist::*;
+
+#[cfg(target_arch = "wasm32")]
+mod _silence_warnings {
+    use gr02 as _;
+    use gr03 as _;
+}

crates/ledger/Cargo.toml

@@ -43,9 +43,8 @@ wasm-bindgen = "0.2.88"
 wasm-bindgen-futures = "0.4.38"
 js-sys = "0.3.65"
 log = "0.4"
-# getrandom = { version = "0.3", features = ["wasm_js"] }
 
-[target.'cfg(target_arch = "wasm32")'.dev-dependencies]
+[dev-dependencies]
 tokio = { version = "1.34", features = ["rt", "macros"] }
 serial_test = "2"
 

crates/ledger/tests/integration.rs

@@ -16,9 +16,9 @@ fn ledger_device_path() {
     println!("{manufacturer:?}");
 }
 
-#[tokio::test]
-#[serial]
 #[ignore]
+#[serial]
+#[tokio::test]
 async fn exchange() {
     let transport = transports::Ledger::init()
         .await