Skip to content

Add ability to do nested dropdowns in navbar #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alasdairwilson
Copy link
Member

nested_submenus

This could go upstream I guess but would need to be generalised a fair bit I expect.

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I have one major issue, but a couple of associated nerd snipes.

My main issue is the changing of the hover-over styling:

before:
image

after:
image

My other requests are:

  1. How would we feel about this being a concertina style thing where we have subsections of the menu expanding rather than popping out to the right?
  2. Is there any chance you can make this code handle the case where the menu goes off the bottom of the display? (i.e. by collapsing the main list?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants