Skip to content

Add a slim builder that doesn't call to_string right away #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

sunsided
Copy link
Owner

@sunsided sunsided commented Jun 7, 2024

This addresses the ideas behind #6. It uses a recursive type construction outlined in this gist and can deal with any type (and type reference).

@sunsided sunsided self-assigned this Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 87.98283% with 28 lines in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (873c41d) to head (9fe6196).

Current head 9fe6196 differs from pull request most recent head d58a2e3

Please upload reports for the commit d58a2e3 to get more accurate results.

Files Patch % Lines
src/slim.rs 87.21% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #12      +/-   ##
===========================================
- Coverage   100.00%   92.62%   -7.38%     
===========================================
  Files            1        2       +1     
  Lines          171      393     +222     
===========================================
+ Hits           171      364     +193     
- Misses           0       29      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunsided sunsided force-pushed the feature/slim-builder branch 4 times, most recently from 20da7e5 to 9fe6196 Compare June 7, 2024 22:26
@sunsided sunsided added the enhancement New feature or request label Jun 7, 2024
@sunsided sunsided force-pushed the feature/slim-builder branch from 9fe6196 to d58a2e3 Compare June 7, 2024 22:29
@sunsided sunsided force-pushed the feature/slim-builder branch from d58a2e3 to 8722770 Compare June 7, 2024 22:30
@sunsided sunsided merged commit adc0a3c into main Jun 7, 2024
6 checks passed
@sunsided sunsided deleted the feature/slim-builder branch June 7, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant