fix: user's cursor can be offset for autocompletion #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose we have an incomplete query and the user's cursor is too far off:
select * from {}
In that case, we couldn't walk the tree-sitter tree.
When we tried to go to the child node at the cursor position, tree-sitter would stay on the
PROGRAM
node (every tree's head) which lead to unexpected contexts and infinite recursion.That's now fixed! We simply "move the cursor" to the previous node:
select * from {}
becomesselect * from{}
.Note: Treesitter is already able to deal with
{} select * from
.Some additional stuff:
tree-print
script to thejustfile
(that's much cooler than Makefile, btw)tree_print
binary to ignore newlines