Skip to content

fix(vscode-ext.): use pg_cli #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Jan 6, 2025

The VSCode extension now uses the pg_cli 🙌

@juleswritescode
Copy link
Collaborator Author

The LSP fails immediately when I change a statement, apparently due to an assertion:

Screenshot 2025-01-06 at 11 37 56

@juleswritescode juleswritescode changed the title fix(vscode-ext.): use pg_cli [based on completions PR] fix(vscode-ext.): use pg_cli Jan 6, 2025
@psteinroe
Copy link
Collaborator

psteinroe commented Jan 6, 2025

@juleswritescode that's on me, I will look at this this week. Can you send me the file your are editing and what edit you make where?

@juleswritescode
Copy link
Collaborator Author

juleswritescode commented Jan 6, 2025

I can replicate the error by removing/readding the semicolon like so:

Screen.Recording.2025-01-06.at.12.25.00.mov

Good news, starting the lsp-proxy works just fine, the error is unrelated :)

select
  id,
  name,
  test1231234123,
  unknown
from
  co;

select
  *
from
  test;

select 

alter table test
drop column id;

select
  lower();

@juleswritescode juleswritescode marked this pull request as ready for review January 6, 2025 13:22
@juleswritescode juleswritescode changed the title [based on completions PR] fix(vscode-ext.): use pg_cli fix(vscode-ext.): use pg_cli Jan 6, 2025
@psteinroe psteinroe merged commit bfc5a40 into supabase-community:main Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants