-
Notifications
You must be signed in to change notification settings - Fork 100
feat(completions): ts_query package, column autocompletion #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
psteinroe
merged 11 commits into
supabase-community:main
from
juleswritescode:feat/ts-queries
Jan 10, 2025
Merged
feat(completions): ts_query package, column autocompletion #168
psteinroe
merged 11 commits into
supabase-community:main
from
juleswritescode:feat/ts-queries
Jan 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
commented
Jan 8, 2025
b3d287a
to
646440e
Compare
juleswritescode
commented
Jan 8, 2025
juleswritescode
commented
Jan 8, 2025
juleswritescode
commented
Jan 8, 2025
psteinroe
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice and clean, love it!! answered your questions and left few comments but overall lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
pg_treesitter_queries
crate which cares about extracting useful information from a tree-sitter tree (such as "which tables are mentioned?")In sum, that makes it such that we have smart autocompletion for columns – see the test cases in
pg_completions/src/complete.rs
for a sneakpeek :)I chose to put the
pg_treesitter_queries
into their own crate so we can reuse them forpg_hover
and the likes.In addition, I created an
InputQuery
struct for ourtest_helpers
which enforces that callers put aCURSOR_POS
into their queries – I had a nasty bug before because I forgot to do it.