Skip to content

Chore: Unit Tests for Individual Filters #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acupofjose opened this issue Nov 28, 2020 · 2 comments
Closed

Chore: Unit Tests for Individual Filters #15

acupofjose opened this issue Nov 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@acupofjose
Copy link
Contributor

Chore

Describe the chore

In the process of creating the Not shorthand methods, I've noticed that some of the filter requests are not necessarily being formed correctly. For instance, contains and includes while similar in functionality, require different request formatting.

Per filter tests will be required based off of: http://postgrest.org/en/v7.0.0/api.html#operators

@acupofjose acupofjose added the enhancement New feature or request label Nov 28, 2020
@acupofjose
Copy link
Contributor Author

Interestingly, attempting to use the contains operator gives me an error:

{
"hint": "No operator matches the given name and argument types. You might need to add explicit type casts.",
"details": null,
"code": "42883",
"message": "operator does not exist: text @> unknown"
}

As though postgrest doesn't know how to use it's own operator?

@elrhomariyounes
Copy link
Contributor

@acupofjose We can close this for now all filters have tests, still to support some types in contains and contained filters as mentioned in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants