Skip to content

fix: use proper dual packaging #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

fix: use proper dual packaging #1139

merged 2 commits into from
May 22, 2024

Conversation

soedirgo
Copy link
Member

soedirgo added 2 commits May 21, 2024 23:49
Support CommonJS & ESM. Previously the ESM build (dist/module) is broken - it's recognized as CommonJS.

For more on dual-packaging: https://nodejs.org/api/packages.html#dual-commonjses-module-packages
@soedirgo soedirgo requested a review from thorwebdev May 21, 2024 15:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9177557277

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.948%

Totals Coverage Status
Change from base Build 9094297610: 0.0%
Covered Lines: 90
Relevant Lines: 117

💛 - Coveralls

Copy link
Contributor

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@soedirgo soedirgo merged commit fe21f2f into master May 22, 2024
1 check passed
@soedirgo soedirgo deleted the fix/proper-dual-packaging branch May 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants