Rewrote package and abort system #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated engine in package, as well as fixed a typo
- changed .add method to follow standard pattern for res and err callbacks to make it easier for promise patterns. - changed constructor to be able to set timeouts and retries in the constructor - split out the timeout logic and retry logic to seperate engines
rewrote pacakge
added abort on timeout
|
Please set a versioning label of either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
.addmethod changed params to(fn, callback, error callback)for more compatibility with promisesThere is an Abort controller for handling abort signals in your promise but not required.
Changes: