bugfix for `.keyboard-raycastable' added unsafely #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes bug described [here](supermedium#26 (comment)) and shown [here](). You can remix that glitch and swap out commented line 193/192 to see the effect of this change there. Basically: ``` "".split(",") // -> [""] [""].push(".selector") // -> ["",".selector"] ["",".selector"].join(",") // -> ",.selector" ```
…ta.objects is an array instead of string fix for error `raycaster.objects.split is not a function`, because this can be an array instead of a string; when I hit the error, I was able to see at that point in execution: ``` console.log(raycaster.data.objects) //=> ["[gui-interactable]", ".raycastable"] ```
fix for "raycaster.objects.split is not a function" when raycaster.data.objects is an array instead of string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug described here and shown here. You can remix that glitch and swap out commented line 193/192 to see the effect of this change there.
Basically:
raycaster then interprets ",.selector" as a faulty css selector down the line in raycaster.js line 152, here: