Skip to content

bugfix for `.keyboard-raycastable' added unsafely #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

bugfix for `.keyboard-raycastable' added unsafely #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4fef5e
bugfix for `.keyboard-raycastable' added unsafely
kylebakerio Dec 29, 2020
638735d
fix for "raycaster.objects.split is not a function" when raycaster.da…
kylebakerio Jul 19, 2021
3909ef6
fix error in prior update
kylebakerio Jul 19, 2021
6024ec6
fix typo in last commit
kylebakerio Jul 19, 2021
71edb49
lingering fix
kylebakerio Sep 2, 2022
5ef4ddb
Merge pull request #1 from kylebakerio/kylebakerio-patch-3
kylebakerio Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dist/aframe-super-keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,11 @@ AFRAME.registerComponent('super-keyboard', {
} else {
this.hand.ownRaycaster = false;
if (this.data.injectToRaycasterObjects) {
var objs = raycaster.data.objects.split(',');
var objs = raycaster.data.objects
if (typeof raycaster.data.objects === "string") { // can be an array if multiple items already declared
objs = objs.split(',');
objs = objs.filter(a => a !== ""); // prevent end result being ",.selector" by removing empty items in array
}
if (objs.indexOf('.keyboardRaycastable') === -1) {
objs.push('.keyboardRaycastable');
}
Expand Down
Loading