Skip to content

Conversation

@deepjyoti30-st
Copy link
Contributor

@deepjyoti30-st deepjyoti30-st commented May 9, 2025

Summary of change

This PR adds support for automatically inferred types of request/response body, query parameters etc in the querier class.

Related issues

Test Plan

All tests should pass.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • webJsInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

@deepjyoti30-st deepjyoti30-st changed the base branch from master to 0.15 May 9, 2025 06:35
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

size-limit report 📦

Path Size
lib/build/index.js 27.5 KB (+0.64% 🔺)
recipe/emailverification/index.js 27.84 KB (+0.58% 🔺)
recipe/emailpassword/index.js 27.88 KB (+0.92% 🔺)
recipe/thirdparty/index.js 28.58 KB (+0.57% 🔺)
recipe/session/index.js 24.47 KB (0%)
recipe/passwordless/index.js 28.94 KB (+0.89% 🔺)
recipe/userroles/index.js 24.74 KB (0%)
recipe/multitenancy/index.js 27.24 KB (+0.67% 🔺)
recipe/multifactorauth/index.js 27.3 KB (+0.56% 🔺)
recipe/totp/index.js 27.03 KB (+0.5% 🔺)
recipe/oauth2provider/index.js 26.89 KB (-2.03% 🔽)
recipe/webauthn/index.js 31.59 KB (+0.88% 🔺)

@deepjyoti30-st deepjyoti30-st changed the title feat/dynamically inferred sdk return types feat: dynamically inferred sdk return types May 15, 2025
@deepjyoti30-st deepjyoti30-st marked this pull request as ready for review May 16, 2025 07:53
@deepjyoti30-st deepjyoti30-st requested a review from porcellus May 16, 2025 08:18
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review how query params are set, I'm not sure if the current changeset is equivalent

@deepjyoti30-st deepjyoti30-st requested a review from porcellus June 3, 2025 06:30
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this on a call; I'm still a bit confused about how the queryparams are set in the request.

@deepjyoti30-st deepjyoti30-st requested a review from porcellus July 7, 2025 12:58
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size check is failing plus there is some issue with the pre-commit hook one as well.

@deepjyoti30-st
Copy link
Contributor Author

The size check is failing plus there is some issue with the pre-commit hook one as well.

Fixed both of them!

@deepjyoti30-st deepjyoti30-st requested a review from porcellus July 9, 2025 05:48
@porcellus porcellus changed the base branch from 0.15 to 0.16 August 7, 2025 20:55
@porcellus porcellus merged commit 27a3de7 into 0.16 Aug 7, 2025
6 of 7 checks passed
@porcellus porcellus deleted the feat/dynamically-inferred-sdk-return-types branch August 7, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants