added highlighting effects for the active navbar links for both day/night modes #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for creating a PR for your Issue!
|
|
@supriya46788 The issue has been resolved as per issue #646. |
|
@umaima06 please resolve the conflicts |
|
@supriya46788 I resolved the conflicts. |
|
@umaima06 i checked it and its not consistent especially on dark mode...only the screenshot you have uploaded works..else are same like before making it inconsistent ...and same goes to light mode, check again if everything looks fine and upload screen recording |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@supriya46788
This PR resolves the issue #646.
I have added a soft beige glow highlight for the navbar pills in the light mode across all the pages-
For the dark mode, its bright orangish glow when the navbar button is being clicked. The vibrant orange glow adds some color to the website when in dark mode across all the pages.