Skip to content

Commit ea37020

Browse files
authored
chore: random todos (#15541)
closes #<!-- Add the related issue number here. Repeat this line for each additional issue it closes --> <!-- Explain the goal of the PR, why it is needed, and what has been changed to achieve that goal --> --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
1 parent d587c2e commit ea37020

File tree

9 files changed

+18
-24
lines changed

9 files changed

+18
-24
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"test:vite-ecosystem-ci": "pnpm --dir packages/kit test",
1616
"test:others": "pnpm -r --filter='./packages/*' --filter=!./packages/kit/ --workspace-concurrency=1 test",
1717
"check": "pnpm -r prepublishOnly && pnpm -r check",
18-
"lint": "pnpm -r lint && eslint --cache --cache-location node_modules/.eslintcache 'packages/**/*.js'",
18+
"lint": "pnpm -r lint && echo '\nRunning eslint...' && eslint --cache --cache-location node_modules/.eslintcache 'packages/**/*.js'",
1919
"format": "pnpm -r format",
2020
"precommit": "pnpm format && pnpm lint",
2121
"changeset:version": "changeset version && pnpm -r generate:version && git add --all",
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
export { BROWSER as browser, DEV as dev } from 'esm-env';
2+
// TODO: write these to disk
23
export { building, version } from '__sveltekit/environment';
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script>
2-
let { children } = $props();
2+
const { children } = $props();
33
</script>
44

55
{@render children()}

packages/kit/src/utils/url.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { BROWSER, DEV } from 'esm-env';
66
*/
77
export const SCHEME = /^[a-z][a-z\d+\-.]+:/i;
88

9-
const internal = new URL('sveltekit-internal://');
9+
const internal = new URL('a://');
1010

1111
/**
1212
* @param {string} base

packages/kit/test/apps/basics/src/routes/errors/nested-error-page/+error.svelte

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
<script>
22
import { page } from '$app/state';
3-
4-
let answer = 42; // TODO migration leftover, was returned from load previously
53
</script>
64

75
<h1>Nested error page</h1>
86
<p id="nested-error-status">status: {page.status}</p>
97
<p id="nested-error-message">error.message: {page.error && page.error.message}</p>
10-
<p id="nested-error-loaded">answer: {answer}</p>
118

129
<style>
1310
h1 {

packages/kit/test/apps/basics/src/routes/load/unchanged-parent/+layout.svelte

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/kit/test/apps/basics/src/routes/load/unchanged-parent/uses-parent/[slug]/+page.svelte

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,10 @@
66
<h1>slug: {data.slug}</h1>
77
<h2>count: {data.count}</h2>
88
<h3>doubled: {data.doubled}</h3>
9+
10+
<ul>
11+
<li><a href="/load/unchanged-parent/isolated/a">/load/unchanged-parent/isolated/a</a></li>
12+
<li><a href="/load/unchanged-parent/isolated/b">/load/unchanged-parent/isolated/b</a></li>
13+
<li><a href="/load/unchanged-parent/uses-parent/a">/load/unchanged-parent/uses-parent/a</a></li>
14+
<li><a href="/load/unchanged-parent/uses-parent/b">/load/unchanged-parent/uses-parent/b</a></li>
15+
</ul>

packages/kit/test/apps/basics/src/routes/load/unchanged/+layout.svelte

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/kit/test/apps/basics/src/routes/load/unchanged/isolated/[slug]/+page.svelte

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,10 @@
55

66
<h1>slug: {data.slug}</h1>
77
<h2>count: {data.count}</h2>
8+
9+
<ul>
10+
<li><a href="/load/unchanged/isolated/a">/load/unchanged/isolated/a</a></li>
11+
<li><a href="/load/unchanged/isolated/b">/load/unchanged/isolated/b</a></li>
12+
<li><a href="/load/unchanged/uses-parent/a">/load/unchanged/uses-parent/a</a></li>
13+
<li><a href="/load/unchanged/uses-parent/b">/load/unchanged/uses-parent/b</a></li>
14+
</ul>

0 commit comments

Comments
 (0)