-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add signal property to request in vite, node environments #13895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 1396477 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Oops! This is a change to kit core too, not just the node adapter. 🤦 |
@sveltejs/adapter-node
@@ -0,0 +1,6 @@ | |||
--- | |||
'@sveltejs/adapter-node': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't actually touch the adapter-node
code at all
'@sveltejs/adapter-node': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does touch @sveltejs/kit/node
, though, and the Node adapter is bundled, so we need to re-build it and release a new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On that note, @sveltejs/kit/node
's getRequest
is also used in local development, in preview
mode, and in production in the Vercel adapter. Is this going to have any impact on those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On that note,
@sveltejs/kit/node
'sgetRequest
is also used in local development, inpreview
mode, and in production in the Vercel adapter. Is this going to have any impact on those?
Yes, it would. Apologies for not being clearer. Though, I wasn't aware that the vercel adapter used getRequest
. I'll mark @sveltejs/adapter-vercel
for a minor version, as well.
this would need some documentation. possibly in the |
Alright. I'll see what I can do. |
12ff4b5
to
2654850
Compare
After a bit of testing behavior in Vercel, I couldn't get the request to hang up early without a body. It works fine on POST requests with data, but will not work on GET requests. I guess it's just a Vercel thing...? Someone else might be able to get it to work, but from what I can see, I don't think Vercel will tell you when the client cancels the request. I've removed the Vercel package from the changeset. On another note though, I squashed my commits and wrote some documentation. It's under the |
Gives routes an AbortSignal (as present in the Request object) to know when the other end hangs up prematurely.
Fixes #12823 for
vite dev+preview
and@sveltejs/adapter-node
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits