Add packaging files so we can use it in our scripts as a dependency #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"./data" is not working, change it to "data/". The trailing slash indicate that it's a directory.
Rename module name from "src" to "mcnn" which sounds like a package name not just a directory name. Add setup.py to make it a package, then it can be install by pip. All dependencies are listed in requirements.txt, however did not give specific version constraint. It can be refine in future.
load image files and show. It does not need gt files.
Add package importing and missing functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the maintainer can upload it to pypi as a python package via pip command, which should be more easier to use by community