Skip to content

[javascript] Remove Buffer usage #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[javascript] Remove Buffer usage #1171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions javascript/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ export class Webhook {
}

public verify(
payload: string | Buffer,
payload: string,
headers_:
| WebhookRequiredHeaders
| WebhookUnbrandedRequiredHeaders
Expand Down Expand Up @@ -850,13 +850,9 @@ export class Webhook {
throw new WebhookVerificationError("No matching signature found");
}

public sign(msgId: string, timestamp: Date, payload: string | Buffer): string {
if (typeof payload === "string") {
// Do nothing, already a string
} else if (payload.constructor.name === "Buffer") {
payload = payload.toString();
} else {
throw new Error("Expected payload to be of type string or Buffer. Please refer to https://docs.svix.com/receiving/verifying-payloads/how for more information.");
public sign(msgId: string, timestamp: Date, payload: string): string {
if (typeof payload !== "string") {
throw new Error("Expected payload to be of type string. Please refer to https://docs.svix.com/receiving/verifying-payloads/how for more information.");
}

const encoder = new TextEncoder();
Expand Down