Conversation
Releases: @swc/plugin-react-remove-properties@12.9.0 @swc/plugin-styled-components@12.9.0 @swc/plugin-transform-imports@12.9.0 @swc/plugin-swc-confidential@11.9.0 @swc-contrib/mut-cjs-exports@14.9.0 @swc/plugin-remove-console@12.9.0 @swc/plugin-experimental-feature-flags@0.8.0 @swc/plugin-styled-jsx@13.9.0 @swc/plugin-swc-magic@12.9.0 @swc/plugin-formatjs@9.9.0 @swc/plugin-prefresh@12.9.0 @swc/plugin-emotion@14.9.0 @swc/plugin-swc-sdk@12.9.0 @swc/plugin-relay@12.9.0 @swc-contrib/plugin-graphql-codegen-client-preset@0.21.0 @swc/plugin-jest@12.9.0 @swc/plugin-loadable-components@11.9.0 @swc/plugin-noop@12.9.0 [skip ci]
|
Code Review: build: Update
|
| Crate | Cargo.toml (new) | Cargo.lock (new) |
|---|---|---|
modularize_imports |
4.0.0 |
3.0.0 |
swc_icu_messageformat_parser |
23.0.0 |
22.0.0 |
swc_emotion |
4.0.0 |
3.0.0 |
swc_formatjs_transform |
27.0.0 |
26.0.0 |
| ... (all 16 crates) |
The lock file consistently reflects versions that are one step behind the Cargo.toml declarations after the version bumps. This suggests the version bump commit (chore(release): bump 16 crate(s)) updated Cargo.toml files but did not regenerate the lock file. While this doesn't break path-based local builds (Cargo resolves path deps by path, not version), it means the published lock file doesn't accurately represent the workspace state and could cause confusion for contributors.
Question: Why was swc_core v64 skipped?
The bump goes directly from 63.1.0 → 65.0.0. The PR body is empty, so there's no explanation. Was v64 a bad release? It would be helpful to note this in the PR description, even briefly.
swc_ecma_minifier major version jump
The minifier goes from 51.1.0 → 52.0.1, which is a major bump. Since plugins consume this transitively through swc_core, this is likely fine — but it's worth confirming that no plugin directly references minifier APIs that may have changed.
Positives
- Version bump pattern is completely consistent across all 18 packages — no packages missed.
- The bundled emotion fix is correctly reflected in the CHANGELOG with both the minor (core update) and patch (keyframes fix) entries.
- The changeset file is properly cleaned up after being merged into the CHANGELOG.
- No logic changes — purely a dependency update, so behavioral risk is low.
Suggestions
- Regenerate
Cargo.lockafter the internal crate version bumps to keep it in sync. Runningcargo generate-lockfileorcargo checkfrom the workspace root after bumping versions should resolve this. - Add a brief PR description noting why v64 was skipped (if intentional) so future bisectors understand the jump.
Overall this is a clean, well-structured release PR following the established conventions of this repo. The Cargo.lock discrepancy is the main technical issue worth addressing before merge.
No description provided.