Skip to content

CI Behavior Inconsistency #10378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bvanjoi opened this issue Apr 16, 2025 · 1 comment
Open

CI Behavior Inconsistency #10378

bvanjoi opened this issue Apr 16, 2025 · 1 comment
Labels
Milestone

Comments

@bvanjoi
Copy link
Contributor

bvanjoi commented Apr 16, 2025

Describe the bug

The test harness exhibits contradictory results across configurations:

  • ​With cargo test -p swc_ecma_parser --test test262 --features verify: falsely passes despite underlying issues.
Image
  • With cargo test -p swc_ecma_parser --test test262 and remove #[cfg(feature = "verify")]: Correctly fails, revealing cases where invalid parses erroneously succeed.
Image

For instance, the test file 08bafe059b17ac92.js contains code that incorrectly passes validation: the parser successfully processes syntax that should trigger failures according to the test specifications

Input code

[+{a = 0}];

Config

Link to the code that reproduces this issue

https://play.swc.rs/?version=1.11.1&code=H4sIAAAAAAAAA4vWrk5UsFUwqI21BgDyJZZNCwAAAA%3D%3D&config=H4sIAAAAAAAAA1WPSw6DMAxE95wi8potm96hh7CCQUH5KQ5SI8Tdm4SElp1n5tkjH4MQsLGElzjymIXHwBRunR1ONuInO0DSIMugfISxpxuXaEHNVK3zSiBiWCnWLZ4aDto5po43zyirlvRfKJ3xgZifYEHRrpqedUOrBOPmvYbtkZh8UbCbGX5QL7sPg%2BJ337zOnl9mc%2BJOFQEAAA%3D%3D

SWC Info output

No response

Expected behavior

parse failed

Actual behavior

parse success

Version

latest commit

Additional context

No response

@bvanjoi bvanjoi added the C-bug label Apr 16, 2025
@kdy1 kdy1 added this to the Planned milestone Apr 16, 2025
@kdy1
Copy link
Member

kdy1 commented Apr 16, 2025

It's because of

#[cfg(feature = "verify")]

It was intended behavior, but feel free to fix it in an ideal way (in your opinion) if you want to 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants