feat(swc/common): allow to take inner from versioned (#5060: Part 2) #5071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I made this PR intentionally short for the verification of idea (which means I'm not certain about this change and I may wrong 😅)
PR implements
take
for theVersionedSerializable
to move out value after deserializaiton is done from transform. Pseudocodewise, it'll be used like below:Main thing I'm unsure is implementing
Default
for theProgram
to usemem::take
in here. It maybe harmless, but I'm not easily able to say default impl for the program is exactly right. Maybe 1. either default should not be implemented 2. or implement better default ?BREAKING CHANGE:
Related issue (if exists):
#5060