Skip to content

Conversation

calebcartwright
Copy link
Member

Changes

  • Adds rustfmt PR check
  • Adds clippy PR check (fails on warnings, runs against all targets)
  • Fixes clippy findings

Related Issues

@calebcartwright calebcartwright added devops Work related to DevOps practices like CI and CD and/or tools done Work on the Issue or PR is completed developer experience Related to developer experience and/or tools labels Aug 21, 2019
@calebcartwright calebcartwright added this to the 1.x Release milestone Aug 21, 2019
@calebcartwright calebcartwright self-assigned this Aug 21, 2019
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #71   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         169    169           
=====================================
  Hits          169    169
Impacted Files Coverage Δ
src/hooks.rs 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd02d82...5be09ed. Read the comment docs.

@calebcartwright
Copy link
Member Author

calebcartwright commented Aug 22, 2019

The coverage thing is really weird. I had the explicit return statements in that file even though it's unnecessary/not the idiomatic way, because I'd seen this before where kcov seems to think the closing } of the function is uncovered... somehow

🤷‍♂

I've reverted back to the explicit returns with a clippy disable

@calebcartwright calebcartwright merged commit 0b65ece into master Aug 22, 2019
@calebcartwright calebcartwright deleted the pr-enhancements branch August 22, 2019 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Related to developer experience and/or tools devops Work related to DevOps practices like CI and CD and/or tools done Work on the Issue or PR is completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR builds for rustfmt and clippy
1 participant