ci: include rustfmt and clippy PR checks

.azure-pipelines/pull-requests/clippy.yml

@@ -0,0 +1,23 @@
+trigger: none
+
+pr:
+- master
+
+pool:
+  vmImage: 'Ubuntu-16.04'
+
+steps:
+- script: |
+    curl https://sh.rustup.rs -sSf | sh -s -- -y
+    echo "##vso[task.setvariable variable=PATH;]$PATH:$HOME/.cargo/bin"
+    echo "##vso[task.setvariable variable=cargoBinPath;]$HOME/.cargo/bin"
+  displayName: 'Install Rust'
+
+- script: |
+    rustup component add clippy
+  displayName: 'Install clippy'
+
+- script: |
+    set -eo pipefail
+    cargo clippy --all-targets -- -D warnings
+  displayName: 'Run clippy'

.azure-pipelines/pull-requests/rustfmt.yml

@@ -0,0 +1,24 @@
+trigger: none
+
+pr:
+- master
+
+pool:
+  vmImage: 'Ubuntu-16.04'
+
+steps:
+- script: |
+    curl https://sh.rustup.rs -sSf | sh -s -- -y
+    echo "##vso[task.setvariable variable=PATH;]$PATH:$HOME/.cargo/bin"
+    echo "##vso[task.setvariable variable=cargoBinPath;]$HOME/.cargo/bin"
+  displayName: 'Install Rust'
+
+- script: |
+    rustup component add rustfmt
+  displayName: 'Install rustfmt'
+
+- script: |
+    set -eo pipefail
+    cargo fmt -- --check
+  displayName: 'Run rustfmt'
+

.vscode/cSpell.json

@@ -22,6 +22,7 @@
     "githook",
     "junit",
     "kcov",
+    "pipefail",
     "repo",
     "rustc",
     "rustfmt",

src/config_test.rs

@@ -26,7 +26,7 @@ mod find_config_file_tests {
         let found_file = "rusty-hook.toml";
         let exp_path = format!("{}/{}", root_dir, found_file);
         let file_exists = |path: &str| {
-            if path == &exp_path {
+            if path == exp_path {
                 return Ok(true);
             }
             Ok(false)

src/hooks.rs

@@ -35,6 +35,9 @@ const HOOK_NAMES: [&str; 19] = [
 const CLI_SCRIPT_NAME: &str = "cli.sh";
 const SEMVER_SCRIPT_NAME: &str = "semver.sh";
 
+// For unknown reasons, kcov is reporting an uncovered line for the closing `}`
+// when using the idiomatic expression.
+#[allow(clippy::needless_return)]
 fn get_hook_file_contents() -> String {
     return String::from(HOOK_FILE_TEMPLATE).replace("{{VERSION}}", VERSION);
 }
@@ -55,6 +58,9 @@ fn get_cli_script_file_contents() -> String {
         .replace("{{MINIMUM_ALLOW_PRE}}", minimum_allow_pre)
 }
 
+// For unknown reasons, kcov is reporting an uncovered line for the closing `}`
+// when using the idiomatic expression.
+#[allow(clippy::needless_return)]
 fn get_semver_script_file_contents() -> String {
     return String::from(HOOK_SEMVER_SCRIPT_FILE_TEMPLATE).replace("{{VERSION}}", VERSION);
 }

src/hooks_test.rs

@@ -117,9 +117,9 @@ mod create_hook_files_tests {
     fn errors_when_hook_write_fails() {
         let write_file = |path: &str, _contents: &str, _make_executable: bool| {
             let file_name = &&path[(path.rfind('/').unwrap() + 1)..];
-            match file_name {
-                &EXP_CLI_SCRIPT_NAME => Ok(()),
-                &EXP_SEMVER_SCRIPT_NAME => Ok(()),
+            match *file_name {
+                EXP_CLI_SCRIPT_NAME => Ok(()),
+                EXP_SEMVER_SCRIPT_NAME => Ok(()),
                 _ => Err(String::from("")),
             }
         };
@@ -131,9 +131,9 @@ mod create_hook_files_tests {
     fn errors_when_cli_script_write_fails() {
         let write_file = |path: &str, _contents: &str, _make_executable: bool| {
             let file_name = &&path[(path.rfind('/').unwrap() + 1)..];
-            match file_name {
-                &EXP_CLI_SCRIPT_NAME => Err(String::from("")),
-                &EXP_SEMVER_SCRIPT_NAME => Ok(()),
+            match *file_name {
+                EXP_CLI_SCRIPT_NAME => Err(String::from("")),
+                EXP_SEMVER_SCRIPT_NAME => Ok(()),
                 _ => Ok(()),
             }
         };
@@ -145,9 +145,9 @@ mod create_hook_files_tests {
     fn errors_when_semver_script_write_fails() {
         let write_file = |path: &str, _contents: &str, _make_executable: bool| {
             let file_name = &&path[(path.rfind('/').unwrap() + 1)..];
-            match file_name {
-                &EXP_CLI_SCRIPT_NAME => Ok(()),
-                &EXP_SEMVER_SCRIPT_NAME => Err(String::from("")),
+            match *file_name {
+                EXP_CLI_SCRIPT_NAME => Ok(()),
+                EXP_SEMVER_SCRIPT_NAME => Err(String::from("")),
                 _ => Ok(()),
             }
         };
@@ -166,12 +166,12 @@ mod create_hook_files_tests {
         let exp_semver_contents = get_expected_semver_script_file_contents();
         let write_file = |path: &str, contents: &str, make_executable: bool| {
             let file_name = &&path[(path.rfind('/').unwrap() + 1)..];
-            match file_name {
-                &EXP_CLI_SCRIPT_NAME => {
+            match *file_name {
+                EXP_CLI_SCRIPT_NAME => {
                     assert_eq!(exp_cli_path, path);
                     assert_eq!(exp_cli_contents, contents);
                 }
-                &EXP_SEMVER_SCRIPT_NAME => {
+                EXP_SEMVER_SCRIPT_NAME => {
                     assert_eq!(exp_semver_path, path);
                     assert_eq!(exp_semver_contents, contents);
                 }