Skip to content

Undefined behavior from cereal/rapidjson in unit tests #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
peddie opened this issue Dec 13, 2022 · 1 comment
Open

Undefined behavior from cereal/rapidjson in unit tests #382

peddie opened this issue Dec 13, 2022 · 1 comment

Comments

@peddie
Copy link
Contributor

peddie commented Dec 13, 2022

The error is reported as:

/home/peddie/albatross/third_party/cereal/include/cereal/external/rapidjson/internal/stack.h:117:13: runtime error: applying non-zero offset 16 to null pointer

Here is a CI job that shows this error.

This issue has been fixed in upstream rapidjson in this commit about 2 years ago. Unfortunately cereal bundles its own version of rapidjson directly in the repo rather than relying on upstream or using a submodule, and what’s more, the bundled version appears to be customized for cereal, meaning it’s not a simple copy-and-paste PR to the cereal project.
peddie added a commit that referenced this issue Dec 13, 2022
@peddie
Add sanitizer suppression for #382
a3588cb
peddie added a commit that referenced this issue Dec 13, 2022
@peddie
Add sanitizer suppression for #382
42366b0
@peddie
Copy link
Contributor Author

peddie commented Dec 13, 2022

I've suppressed this error in CI as part of #373.

peddie added a commit that referenced this issue Dec 13, 2022
@peddie
Add sanitizer suppression for #382
b42a79d
peddie added a commit that referenced this issue Dec 13, 2022
@peddie
Add sanitizer suppression for #382
94b115a
peddie added a commit that referenced this issue Dec 13, 2022
@peddie
Add address/undefined behavior/thread sanitizer builds to CI (#373)
46fb87e 
* Fix stack use-after-free in CSV test

* Handle empty data case in Eigen matrix deserialisation

* Avoid using invalid references in group-by tests

* Add sanitizer support and sanitized CI targets

* Add sanitizer suppression for #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peddie