Don't omit "Type" suffix from disambiguation for Swift metatypes

[d-ronnqvist]

Bug/issue #, if applicable: rdar://152496046

Summary

This makes a small bug fix to type signature disambiguation for parameters or return values that are Swift metatypes (Something.Type).

Dependencies

None.

Testing

• Define some overloads where one of the parameters or return values necessary for disambiguation is a metatype. For example:

  public func doSomething(with value: Int) {}
  public func doSomething(with type: BinaryInteger.Type) {}
  

• Write an ambiguous link to these overloads:

  /// ``doSomething(with:)``
  public enum Something {}
  

• The suggestions for what disambiguation to add to should use BinaryInteger.Type instead of just BinaryInteger. (with the trailing .)

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

• Added tests
• Ran the ./bin/test script and it succeeded
• [ ] Updated documentation if necessary

[d-ronnqvist]

@swift-ci please test

[d-ronnqvist]

@swift-ci please test

[patshaughnessy]

Looks good 👍 I was able to reproduce the disambiguation problem using main and then verify it worked as expected using this fix.

[d-ronnqvist]

@swift-ci please test