Skip to content

[6.2] Don't omit "Type" suffix from disambiguation for Swift metatypes #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from
Open

[6.2] Don't omit "Type" suffix from disambiguation for Swift metatypes #1240

wants to merge 1 commit into from

Conversation

d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Jun 17, 2025 •
edited
Loading

  • Explanation: A small bug fix to type signature disambiguation for parameters or return values that are Swift metatypes (Something.Type).
  • Scope: Surprising looking type signature disambiguation suggestions in some cases.
  • Issue: rdar://152496046
  • Risk: Low.
  • Testing: Added test that the Swift metatype is included in the type disambiguation suggestions. Existing automated tests pass.
  • Reviewer: @patshaughnessy
  • Original PR: Don't omit "Type" suffix from disambiguation for Swift metatypes #1230

@d-ronnqvist
Don't omit "Type" suffix from disambiguation for Swift metatypes (swi…
ece3e41 
…ftlang#1230)

* Don't omit "Type" suffix from disambiguation for Swift metatype parameters

rdar://152496046

* Remove trailing commas for compatibility before Swift 6.1
@d-ronnqvist d-ronnqvist requested a review from franklinsch June 17, 2025 09:36
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch Awaiting requested review from franklinsch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@d-ronnqvist