Incorporate review comments; Allow API breakage

andre-richter · andre-richter · commit 11d6de85e6eb · 2025-02-14T17:35:16.000+01:00
diff --git a/Sources/swift-format/Subcommands/DumpConfiguration.swift b/Sources/swift-format/Subcommands/DumpConfiguration.swift
@@ -63,8 +63,7 @@ extension SwiftFormatCommand {
       }
 
       do {
-        let configurationAsJson = try configuration.asJsonString()
-        print(configurationAsJson)
+        print(try configuration.asJsonString())
       } catch {
         diagnosticsEngine.emitError("\(error.localizedDescription)")
         throw ExitCode.failure
diff --git a/api-breakages.txt b/api-breakages.txt
@@ -2,3 +2,4 @@
 ---
 
 API breakage: constructor FileIterator.init(urls:followSymlinks:) has been removed
+API breakage: enumelement SwiftFormatError.configurationDumpFailed has been added as a new enum case

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,7 @@ extension SwiftFormatCommand {`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`do {`
`66`		`- let configurationAsJson = try configuration.asJsonString()`
`67`		`- print(configurationAsJson)`
	`66`	`+ print(try configuration.asJsonString())`
`68`	`67`	`} catch {`
`69`	`68`	`diagnosticsEngine.emitError("\(error.localizedDescription)")`
`70`	`69`	`throw ExitCode.failure`
Original file line number	Diff line number	Diff line change
`@@ -2,3 +2,4 @@`
`2`	`2`	`---`
`3`	`3`
`4`	`4`	`API breakage: constructor FileIterator.init(urls:followSymlinks:) has been removed`
	`5`	`+API breakage: enumelement SwiftFormatError.configurationDumpFailed has been added as a new enum case`