From 92e0ca2a497d5af343403ac0393661b0a91c7ea0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Wed, 19 Feb 2025 13:25:38 +0100 Subject: [PATCH 1/3] Skip flaky performance test on Windows --- .../WhitespaceLinterPerformanceTests.swift | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift b/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift index b50b23aca..7eaa7c6d5 100644 --- a/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift +++ b/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift @@ -6,6 +6,10 @@ import XCTest final class WhitespaceLinterPerformanceTests: DiagnosingTestCase { func testWhitespaceLinterPerformance() { + #if os(Windows) + // https://github.com/swiftlang/swift-format/issues/939 + throw XCTSkip("This test is flaky on Windows") + #endif let input = String( repeating: """ import SomeModule From 3ae278446a80c0f8ae90372c6589c80b40a19e4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Wed, 19 Feb 2025 13:33:15 +0100 Subject: [PATCH 2/3] Fix indentation --- .../WhitespaceLinterPerformanceTests.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift b/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift index 7eaa7c6d5..ee37c2192 100644 --- a/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift +++ b/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift @@ -7,8 +7,8 @@ import XCTest final class WhitespaceLinterPerformanceTests: DiagnosingTestCase { func testWhitespaceLinterPerformance() { #if os(Windows) - // https://github.com/swiftlang/swift-format/issues/939 - throw XCTSkip("This test is flaky on Windows") + // https://github.com/swiftlang/swift-format/issues/939 + throw XCTSkip("This test is flaky on Windows") #endif let input = String( repeating: """ From c63b4da23d96c83ed9c049efaafcab94578ac512 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Wed, 19 Feb 2025 14:04:01 +0100 Subject: [PATCH 3/3] Fix enclosing function is not declared 'throws' --- .../WhitespaceLinterPerformanceTests.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift b/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift index ee37c2192..c969d016a 100644 --- a/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift +++ b/Tests/SwiftFormatPerformanceTests/WhitespaceLinterPerformanceTests.swift @@ -5,7 +5,7 @@ import XCTest @_spi(Testing) import _SwiftFormatTestSupport final class WhitespaceLinterPerformanceTests: DiagnosingTestCase { - func testWhitespaceLinterPerformance() { + func testWhitespaceLinterPerformance() throws { #if os(Windows) // https://github.com/swiftlang/swift-format/issues/939 throw XCTSkip("This test is flaky on Windows")