Skip to content

Add command line flag to enable experimental features #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add command line flag to enable experimental features #8665

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7ec83
Add command line flag to enable experimental features
suzannaratcliff May 13, 2025
2dfcbfc
Update command line name and type
suzannaratcliff May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sources/Commands/SwiftTestCommand.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,11 @@ struct TestEventStreamOptions: ParsableArguments {
@Option(name: .customLong("attachments-path"),
help: "Path where attachments should be written (Swift Testing only). This path must be an existing directory the current user can write to. If not specified, any attachments created during testing are discarded.")
var attachmentsPath: AbsolutePath?

/// If experimental features should be enabled..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
/// If experimental features should be enabled..
/// If experimental features should be enabled.

@Option(name: .customLong("enable-experimental-features"),
help: .private)
var enableExperimentalFeatures: Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline, I made a suggestion that we scope this flag more narrowly, to only apply to one feature (singular instead of plural) and accept the name of that feature as an argument. The problem with having a single, catch-all “enable all the experimental features” flag is the next time someone adds some new experimental thing, if someone was already passing the flag then they will break.

}

struct TestCommandOptions: ParsableArguments {
Expand Down