Skip to content

[6.2] swift-package-migrate: Miscellaneous low-risk improvements and more tests #8967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025

Conversation

AnthonyLatsis
Copy link
Contributor

@AnthonyLatsis AnthonyLatsis commented Jul 24, 2025

  • Explanation:
    • Improve command-line option descriptions. Be clear that both options accept a comma-separated list, which is not at all obvious, and also state the default for --target.
    • Add tests for feature resolution errors. This change also extracts feature resolution into a method and removes a superfluous colon from the 'unsupported feature' error message.
    • Add more clarity to manifest update error message along with some tests for it.
  • Scope: swift package migrate, essentially diagnosticQoI changes and NFC amendments to string literals.
  • Issues: —
  • Original PRs: swift-package-migrate: Miscellaneous low-risk improvements and more tests #8965.
  • Risk: Very low.
  • Testing: Regression test added.
  • Reviewers: @bkhouri

Be clear that both options accept a comma-separated list, which is not
at all obvious, and also state the default for `--target`.

(cherry picked from commit acbc716)
This change also extracts feature resolution into a method and removes
a superfluous colon from the 'unsupported feature' error message.

(cherry picked from commit 8486081)
@AnthonyLatsis AnthonyLatsis requested a review from a team as a code owner July 24, 2025 04:40
@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test

@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test

@AnthonyLatsis AnthonyLatsis enabled auto-merge (rebase) July 24, 2025 07:13
AnthonyLatsis added a commit that referenced this pull request Jul 24, 2025
… the diagnostic emitter"

This reverts commit a286293.

See discussion at
#8967 (comment).
@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test Windows

@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test Linux

AnthonyLatsis added a commit that referenced this pull request Jul 24, 2025
… the diagnostic emitter"

This reverts commit a286293.

See discussion at
#8967 (comment).
@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test

@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test Windows

1 similar comment
@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test Windows

@AnthonyLatsis AnthonyLatsis merged commit d120823 into release/6.2 Jul 25, 2025
6 checks passed
@AnthonyLatsis AnthonyLatsis deleted the jepa-release branch July 25, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants