-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[6.2] swift-package-migrate: Miscellaneous low-risk improvements and more tests #8967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be clear that both options accept a comma-separated list, which is not at all obvious, and also state the default for `--target`. (cherry picked from commit acbc716)
This change also extracts feature resolution into a method and removes a superfluous colon from the 'unsupported feature' error message. (cherry picked from commit 8486081)
@swift-ci please test |
xedin
requested changes
Jul 24, 2025
b983d8d
to
fa74015
Compare
xedin
approved these changes
Jul 24, 2025
@swift-ci please test |
AnthonyLatsis
added a commit
that referenced
this pull request
Jul 24, 2025
… the diagnostic emitter" This reverts commit a286293. See discussion at #8967 (comment).
@swift-ci please test Windows |
@swift-ci please test Linux |
AnthonyLatsis
added a commit
that referenced
this pull request
Jul 24, 2025
… the diagnostic emitter" This reverts commit a286293. See discussion at #8967 (comment).
(cherry picked from commit e1deb23)
fa74015
to
fabba08
Compare
@swift-ci please test |
@swift-ci please test Windows |
1 similar comment
@swift-ci please test Windows |
bnbarham
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--target
.swift package migrate
, essentially diagnosticQoI changes and NFC amendments to string literals.