FreeBSD: Fix more compiler tests #83319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like on 64-bit Android and arm64 Linux, arm64 FreeBSD uses 128 bit long doubles, which is not supported by Swift resulting in powl to fail to import and failing the test. swiftlang#51573
ASAN hangs on aarch64 FreeBSD. Disabling until we have a chance to dig through it.
Swift defaults to PIC everywhere. The Swift toolchain clang emits PIC relocatable objects by default without passing `-fPIC` on Linux, so the emitted Client.o is relocatable. This is not the case on FreeBSD, where clang uses the static relocation model by default resulting in a link failure due to mixing relocations with non-relocatable objects. ``` ld.lld: error: relocation R_X86_64_64 cannot be used against local symbol; recompile with -fPIC ``` Passing `-fPIC` where needed.
Disabling a few tests. The distributed tests are failing for the same reason they fail on Linux, the rpaths and library search paths are mucked up. Fixing that shouldn't be too hard, but should be enabled on both platforms at once. CollectiveTransformers doesn't work because it imports Darwin directly. There is a note that is several years old saying that we should port the test to the other platforms, but that is beyond the scope of this PR at the moment.
|
@swift-ci please test |
xymus
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
PICrelocation model, while on FreeBSD it defaults to static. Swift defaults toPICeverywhere. Passing-fPICto clang to ensure that the built C object is compatible with the Swift object and avoid failing during the link.powlis a 128-bit long double on arm64 FreeBSD, which Swift does not have support for. Same issue as on Linux and Android. Once we have support, this part of the test should be re-enabled.Disables:
rpaths aren't set up correctly on these two tests and fail on Linux and FreeBSD in the same way. They should be re-enabled together.