[CSApply] Key path dynamic member lookup argument is Sendable only if its captures are #83348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed this before because the argument/parameter types are equal.
|
@swift-ci please test |
hamishknight
approved these changes
Jul 28, 2025
… its captures are Previously dynamic member subscript wasn't allowed to use `& Sendable`, since this restriction was lifted the argument cannot simply assume the parameter type any longer, the key path captures have to be checked to determine whether it could be marked as Sendable or not. Resolves: swiftlang#77105 Resolves: rdar://138227393
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously dynamic member subscript wasn't allowed to use
& Sendable,since this restriction was lifted the argument cannot simply assume
the parameter type any longer, the key path captures have to be checked
to determine whether it could be marked as Sendable or not.
Resolves: #77105
Resolves: rdar://138227393