Nightly failure fixes #1586
Merged
Nightly failure fixes #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
award999
commented
May 27, 2025
award999
commented
- Also check "Thenable"'s for no floating promises
- Make command callbacks explicitly async
- Move some tests to unit level
- Provide some arguments to context as stubbing seems flaky on Windows
- Make sure debug extensions are activated before running tests
It times out after long wait so thinking there may be a timing issue here
Don't require activated extension to test these
Only activate first time since never will deactivate
award999
added
the
full-test-run
award999
requested review from
plemarquand and
matthewbastien
and removed request for
adam-fowler,
0xTim,
plemarquand and
matthewbastien
rbenegal
reviewed
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.