Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

Add support for custom requests session (to support exponential backoffs) #144

@TimidRobot

Description

@TimidRobot

Issue

The requests session is currently hardcoded:

session = requests.Session()

Potential Solution

Easiest change would be to allow the user to specify the session in FlickrAPI() and pass it to OAuthFlickrInterface.

The the user could configure exponential backoff themselves:

from requests.adapters import HTTPAdapter
from requests.packages.urllib3.util.retry import Retry
    # Requests configurations
    max_retries = Retry(
        # try again after 5, 10, 20, 40, 80 seconds
        # for specified HTTP status codes
        total=5,
        backoff_factor=10,
        status_forcelist=[403, 408, 429, 500, 502, 503, 504],
    )
    session = requests.Session()
    session.mount("https://", HTTPAdapter(max_retries=max_retries))

etc.

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions