Fix Shell guess for completion when SHELL is empty

tucksaun · tucksaun · commit 2ac01f41bbb2 · 2025-02-20T11:44:18.000+01:00
diff --git a/completion_installer.go b/completion_installer.go
@@ -137,5 +137,9 @@ Add this to the end of your shell configuration file (e.g. <info>"{{ call .RcFil
 }
 
 func GuessShell() string {
-	return path.Base(os.Getenv("SHELL"))
+	if shell := os.Getenv("SHELL"); shell != "" {
+		return path.Base(shell)
+	}
+
+	return ""
 }

Original file line number	Diff line number	Diff line change
`@@ -137,5 +137,9 @@ Add this to the end of your shell configuration file (e.g. <info>"{{ call .RcFil`
`137`	`137`	`}`
`138`	`138`
`139`	`139`	`func GuessShell() string {`
`140`		`- return path.Base(os.Getenv("SHELL"))`
	`140`	`+ if shell := os.Getenv("SHELL"); shell != "" {`
	`141`	`+ return path.Base(shell)`
	`142`	`+ }`
	`143`	`+`
	`144`	`+ return ""`
`141`	`145`	`}`