Merge branch '3.4' into 4.4

fabpot · fabpot · commit 27575bcbc68d · 2020-08-21T19:19:37.000+02:00
* 3.4:
  fix passing arguments to call_user_func_array() on PHP 8
  [Filesystem] fix test on PHP 8
diff --git a/Filesystem.php b/Filesystem.php
@@ -199,7 +199,7 @@ public function remove($files)
     public function chmod($files, $mode, $umask = 0000, $recursive = false)
     {
         foreach ($this->toIterable($files) as $file) {
-            if (true !== @chmod($file, $mode & ~$umask)) {
+            if ((\PHP_VERSION_ID < 80000 || \is_int($mode)) && true !== @chmod($file, $mode & ~$umask)) {
                 throw new IOException(sprintf('Failed to chmod file "%s".', $file), 0, null, $file);
             }
             if ($recursive && is_dir($file) && !is_link($file)) {

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ public function remove($files)`
`199`	`199`	`public function chmod($files, $mode, $umask = 0000, $recursive = false)`
`200`	`200`	`{`
`201`	`201`	`foreach ($this->toIterable($files) as $file) {`
`202`		`- if (true !== @chmod($file, $mode & ~$umask)) {`
	`202`	`+ if ((\PHP_VERSION_ID < 80000 \|\| \is_int($mode)) && true !== @chmod($file, $mode & ~$umask)) {`
`203`	`203`	`throw new IOException(sprintf('Failed to chmod file "%s".', $file), 0, null, $file);`
`204`	`204`	`}`
`205`	`205`	`if ($recursive && is_dir($file) && !is_link($file)) {`